Merge cockroachdb#66489

66489: sql: add ddl_analysis tests for multi-region r=pawalt a=pawalt Previously, ddl_analysis only tested round trips for single-node setups. This is inadequate with the addition of multi-region tables and databases. This patch adds CCL tests for multi-region DDL statements. Release note: None Co-authored-by: Peyton Walters <[email protected]>
sumeerbhola · Jun 25, 2021 · b6598d0 · b6598d0
2 parents 1918976 + 1a329be
commit b6598d0
Show file tree

Hide file tree

Showing 26 changed files with 1,079 additions and 687 deletions.
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -87,7 +87,7 @@
 /pkg/acceptance/             @cockroachdb/sql-experience
 /pkg/base/                   @cockroachdb/server-prs
 /pkg/bench/                  @cockroachdb/sql-queries
-/pkg/bench/ddl_analysis      @cockroachdb/sql-experience
+/pkg/bench/rttanalysis       @cockroachdb/sql-experience
 /pkg/blobs/                  @cockroachdb/bulk-prs
 /pkg/build/                  @cockroachdb/dev-inf
 /pkg/ccl/baseccl/            @cockroachdb/cli-prs
@@ -108,6 +108,7 @@
 /pkg/ccl/testutilsccl/       @cockroachdb/test-eng
 /pkg/ccl/utilccl/            @cockroachdb/server-prs
 /pkg/ccl/workloadccl/        @cockroachdb/sql-experience
+/pkg/ccl/benchccl/rttanalysisccl/     @cockroachdb/sql-experience
 /pkg/clusterversion/         @cockroachdb/kv
 /pkg/cmd/allocsim/           @cockroachdb/kv
 /pkg/cmd/bazci/              @cockroachdb/dev-inf

diff --git a/pkg/BUILD.bazel b/pkg/BUILD.bazel
@@ -4,12 +4,13 @@
 ALL_TESTS = [
     "//pkg/acceptance:acceptance_test",
     "//pkg/base:base_test",
-    "//pkg/bench/ddl_analysis:ddl_analysis_test",
+    "//pkg/bench/rttanalysis:rttanalysis_test",
     "//pkg/bench:bench_test",
     "//pkg/blobs:blobs_test",
     "//pkg/ccl/backupccl/backupresolver:backupresolver_test",
     "//pkg/ccl/backupccl:backupccl_test",
     "//pkg/ccl/baseccl:baseccl_test",
+    "//pkg/ccl/benchccl/rttanalysisccl:rttanalysisccl_test",
     "//pkg/ccl/changefeedccl/cdctest:cdctest_test",
     "//pkg/ccl/changefeedccl/kvfeed:kvfeed_test",
     "//pkg/ccl/changefeedccl/schemafeed:schemafeed_test",

diff --git a/pkg/bench/ddl_analysis/alter_table_bench_test.go b/pkg/bench/ddl_analysis/alter_table_bench_test.go
diff --git a/pkg/bench/ddl_analysis/create_alter_role_bench_test.go b/pkg/bench/ddl_analysis/create_alter_role_bench_test.go