Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct keyboard shortcuts for show page number and invert colors #4624

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

klsbecker
Copy link

  • Updated the default keyboard shortcuts for the following commands:
    • 'Show current page number'
    • 'Show cursor position in document coordinates'
    • 'Invert colors in the document'

This update ensures that the shortcuts match the expected behavior, improving accessibility and user experience.

@GitHubRulesOK
Copy link
Collaborator

GitHubRulesOK commented Nov 6, 2024

Hmm the shifted i reversal for 3.6 is correct

but the existing measure in 3.6 is still
m - show cursor position in document coordinates
image

shifted M I use for Manga as m is already used

image

Shortcuts [
	[
		Cmd = CmdToggleMangaMode
		Key = M
		ToolbarText = Manga
	]
]

@klsbecker
Copy link
Author

Hello,

I tested on Windows, and the default shortcuts are as described in the commit.

@GitHubRulesOK
Copy link
Collaborator

GitHubRulesOK commented Nov 7, 2024

it was normal m key 2 years ago and was introduced as such in 3.0 (2014)
https://github.com/sumatrapdfreader/sumatrapdf/blob/434718934f082471e5654998bb90510a024a8534/docs/md/Version-history.md?plain=1#L245C1-L245C101
#2186 (comment)

and as far as I know has always been normal unshifted m for measure (both in 3.5 and 3.6) "{0, 'm', CmdToggleCursorPosition},"

Invert I did change for 3.6 but also current docs are for current formal release 3.5.# and there the
normal i 3.5 =INVERT but 3.6 = info (historic)
SHIFTED I 3.5=info (problem) but 3.6 = INVERT (preferred)
image

Thus the change will be needed later for the 3.6 and not current 3.5 release
764781a

@kjk
Copy link
Member

kjk commented Nov 7, 2024

Shift + i change needs version info. it's i in 3.5 or earlier and Shift + i in 3.6+

@klsbecker
Copy link
Author

You're absolutely correct. I had Caps Lock on by accident. 🤡

Furthermore, for the new version, the shortcuts related to Shift + i and i must be switched to match the current behavior.

- Updated the default keyboard shortcuts for the following commands:
  - 'Show current page number'
  - 'Invert colors in the document'

This update ensures that the shortcuts match the expected behavior, improving accessibility and user experience.
@klsbecker klsbecker changed the title Correct keyboard shortcuts for display and color commands Correct keyboard shortcuts for show page number and invert colors Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants