-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add last login refresh request event listener #55
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,92 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of Sulu. | ||
* | ||
* (c) MASSIVE ART WebServices GmbH | ||
* | ||
* This source file is subject to the MIT license that is bundled | ||
* with this source code in the file LICENSE. | ||
*/ | ||
|
||
namespace Sulu\Bundle\CommunityBundle\EventListener; | ||
|
||
use Doctrine\ORM\EntityManager; | ||
use Sulu\Bundle\SecurityBundle\Entity\BaseUser; | ||
use Symfony\Component\HttpKernel\Event\FilterControllerEvent; | ||
use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface; | ||
|
||
class LastLoginListener | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. phpdoc |
||
{ | ||
/** | ||
* @var TokenStorageInterface | ||
*/ | ||
protected $tokenStorage; | ||
|
||
/** | ||
* @var EntityManager | ||
*/ | ||
protected $entityManager; | ||
|
||
/** | ||
* @var int | ||
*/ | ||
protected $interval; | ||
|
||
/** | ||
* LastLoginListener constructor. | ||
* | ||
* @param TokenStorageInterface $tokenStorage | ||
* @param EntityManager $entityManager | ||
* @param int $interval | ||
*/ | ||
public function __construct( | ||
TokenStorageInterface $tokenStorage, | ||
EntityManager $entityManager, | ||
$interval = null | ||
) { | ||
$this->tokenStorage = $tokenStorage; | ||
$this->entityManager = $entityManager; | ||
$this->interval = (int) $interval; | ||
} | ||
|
||
/** | ||
* Update the last login in specific interval. | ||
* | ||
* @param FilterControllerEvent $event | ||
*/ | ||
public function onCoreController(FilterControllerEvent $event) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why not on There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @wachterjohannes if I remember it correctly we did that if a query based on active users dont return 0 users when 1 user is online and the last login will be refreshed. |
||
{ | ||
if (!$event->isMasterRequest()) { | ||
return; | ||
} | ||
|
||
if (!$this->interval) { | ||
return; | ||
} | ||
|
||
// Check token authentication availability | ||
if ($this->tokenStorage->getToken()) { | ||
$user = $this->tokenStorage->getToken()->getUser(); | ||
|
||
if (($user instanceof BaseUser) && !($this->isActiveNow($user))) { | ||
$user->setLastLogin(new \DateTime()); | ||
$this->entityManager->flush($user); | ||
} | ||
} | ||
} | ||
|
||
/** | ||
* Check if user was active shortly. | ||
* | ||
* @param BaseUser $user | ||
* | ||
* @return bool | ||
*/ | ||
public function isActiveNow(BaseUser $user) | ||
{ | ||
$delay = new \DateTime($this->interval . ' minutes ago'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. could you configure this string? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @wachterjohannes only want an integer value in the configuration but can set it to seconds so it like the cacheLifetime. ok? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ok (: |
||
|
||
return $user->getLastLogin() > $delay; | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
<?xml version="1.0" ?> | ||
<container xmlns="http://symfony.com/schema/dic/services" | ||
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd"> | ||
<services> | ||
<service id="sulu_community.event_listener.last_login" class="Sulu\Bundle\CommunityBundle\EventListener\LastLoginListener"> | ||
<argument type="service" id="security.token_storage" /> | ||
<argument type="service" id="doctrine.orm.entity_manager" /> | ||
<argument>%sulu_community.last_login.refresh_interval%</argument> | ||
|
||
<tag name="kernel.event_listener" event="kernel.controller" method="onCoreController" /> | ||
<tag name="sulu.context" context="website" /> | ||
</service> | ||
</services> | ||
</container> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,12 @@ | ||
# Upgrade | ||
|
||
## 0.3.0 | ||
|
||
### Parameter `sulu_community.config` was removed | ||
|
||
The whole config as parameter is not longer available the webspaces config | ||
you can get over the `sulu_community.webspaces` parameter. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. calling it There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @wachterjohannes it is not a single webspace it contains all webspaces There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||
|
||
## 0.2.0 | ||
|
||
### Avatar title will use username instead of fullname | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would use
canBeEnabled
and set a default value torefresh_interval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done