Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added address entity also to contact in completion form #105

Conversation

alexander-schranz
Copy link
Member

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
License MIT

What's in this PR?

Added address entity also to contact in completion form.

Why?

Currently there exists no address fields in the completion as the address entity not exist Symfony would not render the fields because of CollectionType behaviour.

Example Usage

CompletionContactType.php:

            $builder->add(
                'contactAddresses',
                CollectionType::class,
                [
                    'label' => false,
                    'entry_type' => CompletionContactAddressType::class,
                    'entry_options' => [
                        'label' => false,
                    ],
                ]
            );

@trickreich trickreich merged commit 245184b into sulu:master Aug 20, 2018
@alexander-schranz alexander-schranz deleted the enhancement/allow-address-fields-in-completion branch February 19, 2019 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants