Add status icons to list #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wachterjohannes
approved these changes
Jun 26, 2020
Metadata/ListMetadataLoader.php
Outdated
| } | ||
|
|
||
| $field->setType('icon'); | ||
| $field->setVisibility('always'); |
There was a problem hiding this comment.
Should the status not also be displayed always also when not having the status with icons /cc @wachterjohannes
There was a problem hiding this comment.
you are right - @luca-rath can you add this?
There was a problem hiding this comment.
would be okay for me, but i wanted to keep it like it was before.
There was a problem hiding this comment.
I think its the most important information on the list so it should always be displayed
| return null; | ||
| } | ||
|
|
||
| $list = $this->xmlListMetadataLoader->getMetadata($key, $locale, $metadataOptions); |
This reverts commit 7be37d1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Show icons instead of text for status in list view.
Why?
Because it was the same in Sulu 1.6