fix: take tolerations into consideration for readiness check

Signed-off-by: Suleyman Akbas <[email protected]>

controllers/lvmcluster_controller.go

@@ -309,17 +309,17 @@ func (r *LVMClusterReconciler) getExpectedVGCount(ctx context.Context, instance
 	}
 
 	for _, deviceClass := range instance.Spec.Storage.DeviceClasses {
-		for i := range nodeList.Items {
-			ignoreDueToNoSchedule := false
-			for _, taint := range nodeList.Items[i].Spec.Taints {
-				if taint.Effect == corev1.TaintEffectNoSchedule {
-					r.Log.V(1).Info("even though node selector matches, NoSchedule forces ignore of the Node",
-						"node", nodeList.Items[i].GetName())
-					ignoreDueToNoSchedule = true
+		for _, node := range nodeList.Items {
+			ignoreDueToTaint := false
+			for _, taint := range node.Spec.Taints {
+				if !corev1helper.TolerationsTolerateTaint(instance.Spec.Tolerations, &taint) {
+					r.Log.V(1).Info("node is ignored because of the taint",
+						"node", node.GetName(), "taint", taint)
+					ignoreDueToTaint = true
 					break
 				}
 			}
-			if ignoreDueToNoSchedule {
+			if ignoreDueToTaint {
 				continue
 			}
 
@@ -328,7 +328,7 @@ func (r *LVMClusterReconciler) getExpectedVGCount(ctx context.Context, instance
 				continue
 			}
 
-			matches, err := corev1helper.MatchNodeSelectorTerms(&nodeList.Items[i], deviceClass.NodeSelector)
+			matches, err := corev1helper.MatchNodeSelectorTerms(&node, deviceClass.NodeSelector)
 			if err != nil {
 				r.Log.Error(err, "failed to match node selector")
 				return 0, err