Update docker infra and fix image building and publishing in CI #60
Conversation
mjgiarlo
force-pushed
the
fix-image-build
branch
2 times, most recently
from
29f7866 to
a762f3c
Compare
| - restore_cache: | ||
| keys: | ||
| - suri-rails-dependencies-{{ checksum "Gemfile.lock" }} | ||
| # fallback to using the latest cache if no exact match is found | ||
| - suri-rails-dependencies- | ||
|
|
There was a problem hiding this comment.
we don't want to cache because ...
There was a problem hiding this comment.
@ndushay Good question! This caching is messed up in a few ways. First, it uses different keys for restore and save (dor-services vs. suri-rails). Second, I don't believe the cache is persisted across runs. So, basically, I think this is copypasta from some of our other repos where caching has been useful (e.g., in our GoLang and React work), and I'm removing it from Ruby/Rails projects whenever I see it.
mjgiarlo
changed the title
|
marking this as hold until I add some request specs that flag errors like sul-dlss-deprecated/hydrus#415 |
Includes: * Return errors as JSON * Convert controller specs to request specs to catch OpenAPI problems * Switch from sqlite to postgres for the underlying database * Spin up postgres in CI * Add .dockerignore file to keep images svelte * Update Dockerfile * Update README * Re-generate binstubs and add puma binstub * Add docker-compose configuration with web and db services
mjgiarlo
force-pushed
the
fix-image-build
branch
from
a762f3c to
47fb476
Compare
mjgiarlo
changed the title
| parameters: | ||
| - name: id | ||
| in: path | ||
| description: druid to return | ||
| required: true | ||
| schema: | ||
| $ref: '#/components/schemas/BareDruid' | ||
| /suri2/namespaces/druids/identifiers: | ||
| /suri2/namespaces/druid/identifiers: |
There was a problem hiding this comment.
This was what was causing the Hydrus build to fail, @ndushay, if you were interested. I added a bunch of request specs to this branch to catch these more easily. (This is part of why we've been moving away from controller specs towards request specs!)
Why was this change made?
To update the docker infrastructure for suri-rails and get the image build working again.
Was the documentation (README, DevOpsDocs, wiki, openapi.yml) updated?
Yes.
Does this change affect how this application integrates with other services?
Yes, will test in argo, dor-services-app, and hydrus.