Replace drop shadow around .sul-embed-container with a simple border. #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,7 +13,7 @@ | |||
| font-family: 'Source Sans Pro', 'Arial Unicode MS', Helvetica, sans-serif; | |||
| font-size: $font-size-base; | |||
| overflow-y: hidden; | |||
| @include shadow(3); | |||
| border: 1px solid #5f574F; | |||
There was a problem hiding this comment.
We shouldn't reference colors directly in our css declarations. This is a color that is defined in SUL Styles as $color-pantone-405 (which we have defined as $sul-border-color in SUL Embed). Can we use that variable here instead if the color itself?
There was a problem hiding this comment.
FWIW, I do see that this was used below (although I don't think in a border context). We should probably fix that too, but don't feel obligated to include that in this PR.
|
worked for me on my laptop. since tommy's on vacation and jessie's suggestion seemed both reasonable and straight-forward, i pushed a commit fixing both of the explicit color references. still works on my laptop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #604
Before:
After:
I've just verified that this seems to work fine with #609