Add new file component #2348
Merged
Add new file component #2348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
force-pushed
the
new-file-component
branch
2 times, most recently
from
17aa875 to
8294750
Compare
jcoyne
force-pushed
the
new-file-component
branch
6 times, most recently
from
2844145 to
cd54f88
Compare
jcoyne
force-pushed
the
new-file-component
branch
from
cd54f88 to
5d63b27
Compare
|
@jcoyne Is there something I need to do to get CSS working, etc. I am getting this when I view the file viewer locally. |
|
@dnoneill did you |
|
@jcoyne. Yup that was it. Thank you. |
dnoneill
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
I am approving but I want to note a couple things
- hide_title=true doesn't seem to work
- There is a weird thing that iframe changes size based on the sidebar. This might not be an issue when it is embedded, but I am noting it.
Screen.Recording.2025-02-06.at.1.53.41.PM.mov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO (as separate PRs):
Ref #2347