-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add download links for current canvas #983
Comments
The goal here is to provide a reasonable sized version of the image? I wonder if we should also constrain the height (thinking of things like piano rolls or other items with extreme aspect ratios..). |
Yep, exactly.
Yeah, if we can also constrain the height to a max value, that would be great. An example piano roll at 1000px wide is still 95537px high, which is four times smaller than the original but still not really a practical improvement. I'm a bit unsure of what to suggest for the max value, though. Something like But you could have a worst case of 1000px by 5000px. Not sure how big a file that would produce. What do you think? Something in the range of 3000px to 5000px as a max height seems okay to me, especially given this situation is not going to happen very often. |
@ggeisler: I feel like Zoomed region for Book mode is going to be problematic. I could be zoomed into the page on the left (and not see the page on the right) yet need to generate a link to the visible area of a canvas that isn't actually visible at all... |
@jkeck You mean problematic in the sense that in the scenario you gave (user is zoomed in on left page but sees zoomed links for both pages in their download options) the user will see a link to a zoomed image not currently in view, correct (as opposed to problematic in terms of generating the correct links)? |
Both could be potentially problematic. I'm not sure what the expected behavior should be for various book scenarios.
In either case, I think the maths may get tricky, but I won't know how tricky until I know what the desired behavior is. |
Okay, let's see if we can settle on a desired behavior and then you can evaluate if it is technically feasible or not. Based on this part of your response above:
I'm wondering: is it potentially feasible to always provide one download link to what's visible in the zoomed area if book view, regardless of whether the zoomed area includes part of the left page, part of the right page, or as in your example, parts of both pages? In other words, could you stitch together a single image even though the canvas contains zoomed portions of two separate images? If so, I think this might be the ideal behavior when zoomed in book view. I believe our main concern is supporting the user who might have zoomed into a view, using book view, where there is relevant information on both pages that that user wants to save (e.g., some sort of illustration or marking that spans both pages), and forcing the user to replicate the zoom level for both pages individually in single-page view would mean more (somewhat tedious) effort. So if it is potentially feasible to create a single downloadable image of whatever is visible in book view, I think that would be a fine alternative to the original proposal for separate download links for each page in book view. |
Hmmm, I don't know of a good way off the top of my head, and I don't know how robust/performant a client-side library would be for this sort of thing. Perhaps that's worth spinning out into a separate issue? (and I could remove the link in Book view for the time being) |
Sure, sounds good to me. Do you mind creating a new issue to track this, since you could probably toss in some technical details to help us remember the potential technical concerns? |
Other tasks spun out into separate issues. |
Part of #981. Assumes the work in #982 to create the dialog is done.
h3
typography.body1
typography.1000px
. Only display this link if the full-size image is more than 1000px wide.Example: Canvas open with no zoom
Example: Canvas open and zoomed
Example: No-download object
I think we're already doing this with the current SUL-embed, but just as an example of another variation, if the object is a
no-download
object we'll need to adjust the links so that we only offer options that are400px
on the long side:(There might be other implications based on the authentication UI design that is TBD.)
Book view
In book view there are usually two images displayed side-by-side, so when in book view, the download dialog should follow the same approach as with the single canvas view described above, but should do so for each of the two canvases show in the view.
h3
, and then include links for zoomed region, full-size whole image, and 1000px width version of the image, as applicable.h3
, and follow the same guidelines as above for the other links.Example: Two canvases shown in book view, not zoomed
Example: Two canvases shown in book view and zoomed
Gallery view
Only one item can be the current item in gallery view, so the download action should treat that item as the canvas image to download.
Example: First canvas of object selected in gallery view
The text was updated successfully, but these errors were encountered: