Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle "Zoomed image" download links in book mode #10

Open
jkeck opened this issue Jun 4, 2019 · 1 comment
Open

Handle "Zoomed image" download links in book mode #10

jkeck opened this issue Jun 4, 2019 · 1 comment

Comments

@jkeck
Copy link
Member

jkeck commented Jun 4, 2019

We currently do not render the "Zoomed image" link in book mode. The current method for getting the current viewer bounds (OSDViewer.viewer.viewport.getBounds()) doesn't work as-is in Book mode (e.g. it ends up giving us a wildly incorrect x parameter).

More info available in sul-dlss/sul-embed#983 (comment)

We have a few options:

  1. "Stitch" together any visible images between two canvases into one image (preferred by @ggeisler)
  2. Render a link in the download under each canvas section that would download the visible section for that particular canvas.
    • If we do this, then we need to know what to do when one canvas is not visible (e.g. not display a link)
  3. Other possibilities...?
@ggeisler
Copy link

ggeisler commented Jun 4, 2019

For option #2:

If we do this, then we need to know what to do when one canvas is not visible (e.g. not display a link)

Yes, I would just provide a download link for the image that is visible and omit it for the other one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants