V3 annotation, annotationPage and choice object improvements #30
Conversation
ndushay
changed the title
|
|
||
| def required_keys | ||
| super + %w{ motivation } | ||
| super + %w{ id motivation target } |
There was a problem hiding this comment.
I'm not seeing target anywhere in the Presentation 3.0 API JSON-examples. Where does this come from?
There was a problem hiding this comment.
Annotation itself isn't in the 3.0 API; it has its own spec: http://www.openannotation.org/spec/core/ In the spec it is hasTarget but our JSON expresses it as target
I learned about Annotations for the Triannon linked data project I did a while ago; but mostly I looked at examples -- our purl, Tom Crane's, etc.
| def prohibited_keys | ||
| super + CONTENT_RESOURCE_PROPERTIES + | ||
| %w{ first last total nav_date viewing_direction start_canvas content_annotations } | ||
| end |
There was a problem hiding this comment.
Looking through the 3.0 (alpha) spec, I couldn't find e.g. content_annotations. I guess I must be missing something, otherwise you wouldn't have added this?
There was a problem hiding this comment.
contentAnnotations is how it would appear in the spec.
I believe the individual commit messages express what this PR is about.
connected to #6