V3 resource and image_resource tests improved #29
Conversation
ndushay
force-pushed
the
v3-image_resource-tests
branch
from
0f5d8b4 to
e21f37e
Compare
ndushay
force-pushed
the
v3-image_resource-tests
branch
from
e21f37e to
52c15cc
Compare
There was a problem hiding this comment.
one question, one very minor style nitpick repeated a few times. if putting multi-line blocks in curly braces is a convention that's already in use in the project, i'd disregard those comments entirely. not a thing i care one way or the other about in the first place, and i wouldn't detract from consistency just to mollify a style checking complaint i've seen on other projects.
but overall, definite 👍, happy to merge as-is if you think that's the right thing to do. no substantial changes to suggest from me.
| let(:file_id) { 'https://example.org/file/abc666/ocr.txt' } | ||
| let(:file_type) { 'Document' } | ||
| let(:file_mimetype) { 'text/plain' } | ||
| let(:resource_object) { |
There was a problem hiding this comment.
i think i've seen rubocop complain about not using the do form for multiline blocks. not a thing that bothers me personally, and not sure how much others care about that convention, but just FYI in case that makes you want to change this.
There was a problem hiding this comment.
oh yeah - I've seen that too. At this point, I think I'm inclined to just let it ride.
| }] | ||
| ) | ||
| } | ||
| let(:resource_object_w_login) { |
There was a problem hiding this comment.
ditto multiline block on this and let(:login_service) (if you change the one in the preceding test)
| def validate | ||
| super | ||
|
|
||
| unless self['id'] =~ /^https?:/ |
There was a problem hiding this comment.
the superclass takes care of validating against the more general URI::regexp, right?
| end | ||
| describe 'realistic examples' do | ||
| let(:img_id) { 'https://example.org/image/iiif/abc666' } | ||
| let(:image_v2_service) { |
There was a problem hiding this comment.
ditto multi-line block if you decide to change
| describe 'stanford' do | ||
| describe 'thumbnail per purl code' do | ||
| let(:thumb_id) { "#{img_id}/full/!400,400/0/default.jpg" } | ||
| let(:thumb_object) { |
There was a problem hiding this comment.
ditto multi-line block if you decide to change
| end | ||
| describe 'full size per purl code' do | ||
| let(:full_id) { "#{img_id}/full/full/0/default.jpg" } | ||
| let(:image_object) { |
There was a problem hiding this comment.
ditto multi-line block if you decide to change
| describe 'requires login' do | ||
| let(:service_label) { 'login message' } | ||
| let(:token_service_id) { 'https://example.org/iiif/token' } | ||
| let(:login_service) { |
There was a problem hiding this comment.
ditto multi-line block if you decide to change
| }] | ||
| ) | ||
| } | ||
| let(:image_object_w_login) { |
There was a problem hiding this comment.
ditto multi-line block if you decide to change
| end | ||
| end | ||
| describe 'image examples from http://prezi3.iiif.io/api/presentation/3.0' do | ||
| let(:image_object) { |
There was a problem hiding this comment.
ditto multi-line block if you decide to change
| # "tiles": [{"width": 512, "scaleFactors": [1,2,4,8,16]}] | ||
| # } | ||
| # } | ||
| let(:img_obj) { |
There was a problem hiding this comment.
ditto multi-line block if you decide to change
ndushay
force-pushed
the
v3-image_resource-tests
branch
from
7de92e1 to
7d6f96a
Compare
|
@jmartin-sul I've added the |
Nothing earth shaking here:
profileto Service, a commonly used keyIf it looks good to you, merge it.