Support retaining our auth cookie during payment #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables the cookie to be retained when redirecting to Cybersource during payment, so that we are not logged out when we return from making a payment.
This ensures that we don't get warnings about SameSite=None cookies as a result of 8785e73. The warnings indicate that at some point the browser will no longer honor these cookies unless they are sent securely.
thatbudakguy
force-pushed
the
samesite-cookie
branch
from
bb8bb42 to
387f291
Compare
jcoyne
reviewed
Jul 26, 2023
| @@ -62,4 +62,9 @@ | |||
|
|
|||
| # Annotate rendered view with file names. | |||
| # config.action_view.annotate_rendered_view_with_filenames = true | |||
|
|
|||
| # Chrome (including headless) blocks cookies with SameSite=None (which we set | |||
There was a problem hiding this comment.
Can you add something about Chrome requiring None ; Secure, which we are unable to do in test.
thatbudakguy
force-pushed
the
samesite-cookie
branch
from
b6c49de to
66f88f1
Compare
jcoyne
approved these changes
Jul 26, 2023
thatbudakguy
added a commit
that referenced
this pull request
Jul 31, 2023
See #887; this just applies the same fix we currently use in test to the dev server so that authentication, etc. will work in local dev.
thatbudakguy
added a commit
that referenced
this pull request
Jul 31, 2023
See #887; this just applies the same fix we currently use in test to the dev server so that authentication, etc. will work in local dev.
thatbudakguy
added a commit
that referenced
this pull request
Jul 31, 2023
See #887; this just applies the same fix we currently use in test to the dev server so that authentication, etc. will work in local dev.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the existing behavior where the user is signed out and redirected to the root after making a payment, because once we go out to Cybersource we lose our authentication cookie.