Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support display of payment history from FOLIO #882

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

thatbudakguy
Copy link
Member

Closes #832

@@ -223,6 +223,12 @@ def can_pay_fines?
true
end

def payments
Copy link
Contributor

@marlo-longley marlo-longley Jul 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are merging new code related to the Symphony model, should there be a new test?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this (and symphony_legacy_client) came over from the SymphonyClient, so it's more of a move than new code imo. I just needed it to be here instead of on the client, so that patron.payments worked for both Symphony and FOLIO

@thatbudakguy thatbudakguy force-pushed the transaction-history branch from c8fcd61 to 04ea71b Compare July 20, 2023 16:31
@thatbudakguy thatbudakguy force-pushed the transaction-history branch from 04ea71b to 4cdb187 Compare July 20, 2023 16:38
@marlo-longley marlo-longley merged commit 6ee4a9b into main Jul 20, 2023
@marlo-longley marlo-longley deleted the transaction-history branch July 20, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display billing transaction history for a patron
2 participants