Rails61 redo #665
Merged
Rails61 redo #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cbeer, your original PR looked fine, but I had some trouble resolving conflicts as noted. I'd like to punt back to you to do the merge if that's OK. |
|
@cbeer This is ready for review. If you want to check out a new branch and re-submit it for my review, that's OK with me. I had to request that node be upgraded on -dev in order for to install all the node_modules, so before deploying this tp uat or prod, we will have to check that off as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were conflicts in the Gemfile.lock and deploy problems with the previous
rails61PR. I checked out a new branch from the updatedmainbranch and checked out/added the changed filed from the originalrails61PR.