Fixes Advisory: CVE-2020-26247 #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejackreed
suggested changes
Jan 4, 2021
Gemfile
Outdated
| @@ -44,7 +44,8 @@ gem 'bootstrap', '~> 4.3' | |||
|
|
|||
| gem 'warden' | |||
|
|
|||
| gem 'nokogiri' | |||
| # Fixes Advisory: CVE-2020-26247 | |||
There was a problem hiding this comment.
Can we get away with just doing a bundle update with commenting about the CVE or specifying a version? I mention this just as it might become troublesome to try and keep track of that.
There was a problem hiding this comment.
Ok, I updated the Gemfile.lock and removed the version pinning and changed the Gemfile comment.
There was a problem hiding this comment.
Great! Looks like there is a Rubocop issue still. I would be fine if you wanted to remove the comment entirely.
jgreben
force-pushed
the
jgreben-CVE-2020-26247
branch
from
7b84ca4 to
5fd0e32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.