Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a bit more granular feature flags for the various schedule once … #549

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

jkeck
Copy link
Contributor

@jkeck jkeck commented Jun 4, 2020

…links.

The theory being that because we allow visits to Green doesn't necessarily mean we'll be ready for pickup (even if a valid user has material for pickup) because the library staff may not be ready.

…inks.

The theory being that because we allow visits to Green doesn't necessarily mean we'll be ready for pickup (even if a valid user has material for pickup) because the library staff may not be ready.
@jkeck jkeck force-pushed the more-graunular-ff branch from 22d99ed to 22d5621 Compare June 4, 2020 22:31
@@ -35,3 +35,9 @@ BORROW_DIRECT_CODE: BORROW_DIRECT

schedule_once:
enabled: false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've kept this top-level flag as a convenience to not have to check both accessors before rendering a wrapping element. Would be happy to 🔪 this though.

@mejackreed mejackreed merged commit ec19785 into add-schedule-button Jun 5, 2020
@mejackreed mejackreed deleted the more-graunular-ff branch June 5, 2020 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants