Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canceling a single request #209

Merged
merged 9 commits into from
Jul 26, 2019
Merged

Canceling a single request #209

merged 9 commits into from
Jul 26, 2019

Conversation

mejackreed
Copy link
Contributor

@mejackreed mejackreed commented Jul 23, 2019 •
edited
Loading

  • Cancel a single request that is ready for pickup
  • Change a pickup library that is not yet ready for pickup
  • Change a not needed by date that is not yet ready for pickup
  • Figure out the correct api call for not needed by
  • Figure out how to put what libraries can pickup be changed to
  • Cancel a request that is not yet ready for pickup
  • Put it in a modal Split to Put request change/cancel (edit) form into a modal #242

change

@mejackreed mejackreed force-pushed the 51-single-request branch 6 times, most recently from 791880a to 2ef1e81 Compare July 24, 2019 21:51
@mejackreed mejackreed changed the title Canceling a single request WIP Canceling a single request Jul 24, 2019
@mejackreed mejackreed marked this pull request as ready for review July 24, 2019 21:55
cbeer
cbeer reviewed Jul 24, 2019
View reviewed changes
app/controllers/requests_controller.rb Outdated Show resolved Hide resolved
app/models/library_location.rb Show resolved Hide resolved
app/models/library_location.rb
end

def location_specific_pickup_libraries?
config.location_specific_pickup_libraries.key?(@home_location)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should pull config.location_specific_pickup_libraries out to a private method so it's a little less unwieldy.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great recommendation!

@mejackreed mejackreed force-pushed the 51-single-request branch 2 times, most recently from 8663f08 to 8381ab5 Compare July 25, 2019 14:14
@camillevilla camillevilla self-requested a review July 25, 2019 23:54
camillevilla
camillevilla reviewed Jul 26, 2019
View reviewed changes
Copy link
Contributor

@camillevilla camillevilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mejackreed I was able to create a request in searchworks-morison and successfully change its not needed by date and pickup location, but it looks like I'm getting a 400 on posting the cancelHold request. Could you walk me through this PR tomorrow? Trying to figure out if this is something about my local dev env or something else I'm misunderstanding about this PR.

@mejackreed
Copy link
Contributor Author

@camillevilla oops looks like I had that commented out. I popped on 13d0f1d which should resolve the issue. I had it commented out before I knew about the morison way to create requests.

@camillevilla camillevilla merged commit ff15295 into master Jul 26, 2019
@camillevilla camillevilla deleted the 51-single-request branch July 26, 2019 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbeer cbeer cbeer left review comments

@camillevilla camillevilla camillevilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mejackreed @cbeer @camillevilla