Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need to record fillByDate in FOLIO? #834

Closed
cbeer opened this issue Jun 2, 2023 · 3 comments
Closed

Do we need to record fillByDate in FOLIO? #834

cbeer opened this issue Jun 2, 2023 · 3 comments

Comments

@cbeer
Copy link
Member

cbeer commented Jun 2, 2023

No description provided.

@thatbudakguy
Copy link
Member

symphony holds have a "fill by date". it's not super clear what that does. FOLIO doesn't have it. does that matter? do we still need it?

@saseestone
Copy link

saseestone commented Jun 10, 2023

The fillbydate in Symphony corresponds to the "Not needed after" field in our request forms.

In FOLIO this should correspond to "Request expiration date". Here's what it looks like in the FOLIO UI:

Image

And yes, we need it. This is the way we expire holds created in SearchWorks. If we don't include an expiration date, they live on and on and on and on.

@saseestone saseestone removed their assignment Jun 10, 2023
@cbeer
Copy link
Member Author

cbeer commented Jun 16, 2023

I think FOLIO has two different expiration dates ("holdShelfExpirationDate" and "requestExpirationDate") and mylibrary has two different fields ("Fill by date" and "Expiration date").

Is our "Fill by date" actually the requestExpirationDate, and our expiration date the "holdShelfExpirationDate"?

@cbeer cbeer moved this from 🔖 Ready to 👀 In review in Searchworks/FOLIO Summer 2022/23 Jun 16, 2023
@cbeer cbeer closed this as completed in 862e2fc Jun 19, 2023
cbeer added a commit that referenced this issue Jun 19, 2023
Populate fill_by_date from the request expiration date; fixes #834
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Searchworks/FOLIO Summer 2022/23 Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants