Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add margin & padding to proxy tabs #354

Closed
jvine opened this issue Jul 30, 2019 · 0 comments
Closed

Add margin & padding to proxy tabs #354

jvine opened this issue Jul 30, 2019 · 0 comments
Assignees
@mejackreed

Comments

@jvine
Copy link
Contributor

jvine commented Jul 30, 2019

Feedback from circ staff about the visual distinction of the tabs.

Increase the height of the tabs to 1rem from .5, and increase the vertical space between main-nav and tabs. This worked for me:

.nav-tabs .nav-link {
    padding: 1rem;
    margin-top: 1rem;
}

Before
Screen Shot 2019-07-30 at 2 12 33 PM

After
Screen Shot 2019-07-30 at 2 12 02 PM
@mejackreed mejackreed self-assigned this Jul 31, 2019
mejackreed added a commit that referenced this issue Jul 31, 2019
@mejackreed
Increase top padding fixes #354
c6295b1
mejackreed added a commit that referenced this issue Jul 31, 2019
@mejackreed
Add padding and margin fixes #354
1a7fe5d
@cbeer cbeer closed this as completed in 4c07e67 Jul 31, 2019
cbeer added a commit that referenced this issue Jul 31, 2019
@cbeer
Merge pull request #372 from sul-dlss/354
0c4ab0e 
Add padding and margin fixes #354
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mejackreed mejackreed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mejackreed @jvine