Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling revisit now that nav tabs have data #221

Closed
camillevilla opened this issue Jul 23, 2019 · 4 comments
Closed

Styling revisit now that nav tabs have data #221

camillevilla opened this issue Jul 23, 2019 · 4 comments
Assignees

Comments

@camillevilla
Copy link
Contributor

Examples from 7/23:

Longer summary value forces 4th tab to the next line

Screen Shot 2019-07-23 at 3 41 06 PM

Longer values sometimes force icons and copy onto separate lines

Screen Shot 2019-07-23 at 3 40 48 PM

@cbeer
Copy link
Member

cbeer commented Jul 23, 2019

Could we set a min-width for the page? It seems like Firefox lets you shrink the page more than Safari does.

@jvine
Copy link
Contributor

jvine commented Jul 24, 2019

For #mainnav .info add

    font-size: .9em;
    white-space: nowrap;

For .nav add padding-right: 0;

For .nav-link change padding: 0.5rem 1rem; to padding: 0.5rem;

And then it works on iPhone 5 (320px wide)
Screen Shot 2019-07-23 at 5 09 22 PM

It's possible that a very bad borrower could have a combination of statuses that breaks on iPhone 5, but... I think it will be pretty rare (and the least of their worries).

@cbeer
Copy link
Member

cbeer commented Jul 24, 2019

For .nav-link change padding: 0.5rem 1rem; to padding: 0.5rem 1rem;

From trying things out, I assume this should bepadding: 0.5rem?

@jvine
Copy link
Contributor

jvine commented Jul 24, 2019

D'oh. Yes. Sorry.

camillevilla added a commit that referenced this issue Jul 24, 2019
Update nav tab styling to avoid ugly wrapping; fixes #221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants