Use string class names for instance doubles

sul-dlss · Jun 6, 2022 · 8666d4b · 8666d4b
1 parent 91cd85a
commit 8666d4b
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/spec/controllers/renewals_controller_spec.rb b/spec/controllers/renewals_controller_spec.rb
@@ -3,7 +3,7 @@
 require 'rails_helper'
 
 RSpec.describe RenewalsController, type: :controller do
-  let(:api_response) { instance_double('Response', status: 200, content_type: :json) }
+  let(:api_response) { instance_double(Response, status: 200, content_type: :json) }
   let(:mock_client) do
     instance_double(SymphonyClient, renew_item: api_response, ping: true)
   end
@@ -40,7 +40,7 @@
     end
 
     context 'when the response is not 200' do
-      let(:api_response) { instance_double('Response', status: 401, content_type: :json) }
+      let(:api_response) { instance_double(Response, status: 401, content_type: :json) }
 
       it 'does not renew the item and sets flash messages' do
         post :create, params: { resource: 'abc', item_key: '123' }

diff --git a/spec/controllers/requests_controller_spec.rb b/spec/controllers/requests_controller_spec.rb
@@ -78,7 +78,7 @@
     end
 
     describe '#update' do
-      let(:api_response) { instance_double('Response', status: 200, content_type: :json) }
+      let(:api_response) { instance_double(Response, status: 200, content_type: :json) }
 
       let(:requests) do
         [instance_double(Request, key: '123')]
@@ -154,7 +154,7 @@
     end
 
     describe '#destroy' do
-      let(:api_response) { instance_double('Response', status: 200, content_type: :json) }
+      let(:api_response) { instance_double(Response, status: 200, content_type: :json) }
       let(:mock_client) { instance_double(SymphonyClient, cancel_hold: api_response, ping: true) }
 
       let(:requests) do
@@ -182,7 +182,7 @@
       end
 
       context 'when the response is not 200' do
-        let(:api_response) { instance_double('Response', status: 401, content_type: :json, body: 'foo') }
+        let(:api_response) { instance_double(Response, status: 401, content_type: :json, body: 'foo') }
 
         it 'does not cancel the hold and sets flash messages' do
           delete :destroy, params: { resource: 'abc', id: '123' }

diff --git a/spec/controllers/reset_pins_controller_spec.rb b/spec/controllers/reset_pins_controller_spec.rb
@@ -42,7 +42,7 @@
     end
 
     context 'when everything is good' do
-      let(:response) { instance_double('Response', status: 200, content_type: :json) }
+      let(:response) { instance_double(Response, status: 200, content_type: :json) }
       let(:mock_client) { instance_double(SymphonyClient, change_pin: response, ping: true) }
 
       it 'changes the pin and sets flash messages' do
@@ -57,7 +57,7 @@
     end
 
     context 'when the response is not 200' do
-      let(:response) { instance_double('Response', status: 401, content_type: :json) }
+      let(:response) { instance_double(Response, status: 401, content_type: :json) }
       let(:mock_client) { instance_double(SymphonyClient, change_pin: response, ping: true) }
 
       it 'does not change the pin and sets flash messages' do

diff --git a/spec/services/symphony_client_spec.rb b/spec/services/symphony_client_spec.rb
@@ -129,7 +129,7 @@
     context 'when symphony returns no patron info' do
       before do
         allow(client).to receive(:authenticated_request).and_return(
-          instance_double('HTTP::Response', body: unavailable[:body], status: unavailable[:status])
+          instance_double(HTTP::Response, body: unavailable[:body], status: unavailable[:status])
         )
       end