Adds aria-expanded for See more options. #3187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edsu
reviewed
Jul 6, 2023
| @@ -39,7 +39,7 @@ | |||
| </div> | |||
|
|
|||
| <% unless mixed_material_type? %> | |||
| <a href="#" class="more-options collapsed" data-action="more-types#toggleMoreTypes" data-more-types-target="moreTypesLink"> | |||
| <a href="#" class="more-options collapsed" data-action="more-types#toggleMoreTypes" data-more-types-target="moreTypesLink" aria-expanded="false" role="button"> | |||
There was a problem hiding this comment.
Do you need a aria-controls attribute when using aria-expanded?
edsu
reviewed
Jul 6, 2023
| @@ -65,7 +65,7 @@ | |||
|
|
|||
| <div class="mb-4 subtype-container" data-work-type-modal-target="subtype"></div> | |||
|
|
|||
| <a href="#" class="more-options collapsed" data-action="work-type-modal#toggleMoreTypes" data-work-type-modal-target="moreTypesLink" hidden> | |||
| <a href="#" class="more-options collapsed" data-action="work-type-modal#toggleMoreTypes" data-work-type-modal-target="moreTypesLink" hidden aria-expanded="false" role="button"> | |||
There was a problem hiding this comment.
same question here re: aria-controls
justinlittman
force-pushed
the
see_more_accessibility
branch
from
1487999 to
d86f408
Compare
edsu
approved these changes
Jul 6, 2023
edsu
reviewed
Jul 6, 2023
| this.continueButtonTarget.focus() | ||
| } | ||
|
|
||
| hideMoreTypes() { | ||
| this.moreTypesTarget.hidden = true | ||
| this.moreTypesLinkTarget.innerHTML = 'See more options' | ||
| this.moreTypesLinkTarget.classList.toggle('collapsed', true) | ||
| this.moreTypesLinkTarget.setAttribute('aria-expanded', false) |
There was a problem hiding this comment.
Not a blocker, but do we need aria-controls here too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #3170
Why was this change made? 🤔
How was this change tested? 🤨
⚡ ⚠ If this change involves consuming from or writing to another service (or shared file system), run integration test create_object_h2_spec.rb and/or test manually in [stage|qa] environment, in addition to specs. ⚡
Does your change introduce accessibility violations? 🩺
⚡ ⚠ Please ensure this change does not introduce accessibility violations (at the WCAG A or AA conformance levels); if it does, include a rationale. See the Infrastructure accessibility guide for more detail. ⚡