Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header / footer logo accessibility #3177

Closed
justinlittman opened this issue Jun 30, 2023 · 3 comments · Fixed by #3182
Closed

Header / footer logo accessibility #3177

justinlittman opened this issue Jun 30, 2023 · 3 comments · Fixed by #3182
Assignees
Labels
2023 Summer 2023 workcycle

Comments

@justinlittman
Copy link
Contributor

The image link with the logo for Stanford Libraries has an aria-label in addition to an image with alternative text and both instances have a value of "Stanford Digital Repository" without including the visible Libraries text. (also: "There are images with an alternative text that does not provide a meaningful equivalent. The "Stanford Libraries" logo has "Stanford Digital Repository" as the alternative text.")

@justinlittman
Copy link
Contributor Author

@astridu The logo is:
image

However, it links to https://sdr.stanford.edu/

That seems kinda contradictory (i.e., an image for SUL Libraries that links to SDR) and makes it unclear how to correct the labels.

@justinlittman justinlittman added the question Further information is requested label Jun 30, 2023
@astridu
Copy link

astridu commented Jun 30, 2023

Agree. Let's have the logo link to Stanford Libraries. I looked at other sites, and it looks like they link the 'Stanford University' logo back to the main university page, and then their department name 'Stanford | Engineering' goes to the engineering home. Could we do something similar here where our logo links to Stanford Libraries, and then our name 'Stanford | Digital Repository" goes to SDR home?

@justinlittman
Copy link
Contributor Author

That'll work @astridu.

@justinlittman justinlittman removed the question Further information is requested label Jun 30, 2023
@ndushay ndushay assigned ndushay and unassigned ndushay Jun 30, 2023
@justinlittman justinlittman self-assigned this Jul 5, 2023
justinlittman added a commit that referenced this issue Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2023 Summer 2023 workcycle
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants