Fix flaky tests #1877
Merged
Fix flaky tests #1877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corylown
force-pushed
the
flaky-tests
branch
2 times, most recently
from
2f0cf81 to
d050771
Compare
corylown
force-pushed
the
flaky-tests
branch
from
ee2f2ca to
a309535
Compare
corylown
force-pushed
the
flaky-tests
branch
from
a309535 to
6d2e4bc
Compare
jcoyne
approved these changes
Sep 9, 2024
|
When the test that checks "dismiss and don't show again" runs first the other tests fail because the session where "don't show again" was set is still in effect. I tried a bunch of different ways to deal with this based on reviewing methods available in the Capybara driver (https://github.com/teamcapybara/capybara/blob/master/lib/capybara/selenium/driver.rb) and quitting the driver is the only one that worked reliably. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.