Don't use rubocop-rails 2.8.0 as it introduces a bug.

rubocop/rubocop-rails#349 will hopefully address this in the next release
sul-dlss · Sep 8, 2020 · c732a05 · c732a05
1 parent fe88f5d
commit c732a05
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/Gemfile b/Gemfile
@@ -47,7 +47,8 @@ group :development, :test do
   gem 'rails-controller-testing'
   gem 'rubocop', '~> 0.65'
   gem 'rubocop-performance'
-  gem 'rubocop-rails'
+  # Don't use rubocop-rails 2.8.0 (it has a bug that fails our builds)
+  gem 'rubocop-rails', '> 2.7', '!= 2.8.0'
   gem 'rubocop-rspec'
   gem 'solr_wrapper'
   gem 'webdrivers'

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -472,7 +472,7 @@ GEM
       parser (>= 2.7.1.4)
     rubocop-performance (1.8.0)
       rubocop (>= 0.87.0)
-    rubocop-rails (2.8.0)
+    rubocop-rails (2.7.1)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
       rubocop (>= 0.87.0)
@@ -649,7 +649,7 @@ DEPENDENCIES
   rspec_junit_formatter
   rubocop (~> 0.65)
   rubocop-performance
-  rubocop-rails
+  rubocop-rails (> 2.7, != 2.8.0)
   rubocop-rspec
   sass-rails (~> 5.0)
   selenium-webdriver