[HOLD] Allow rights metadata indexing to function again #466
Conversation
| super | ||
| end | ||
|
|
||
| def dra_object |
There was a problem hiding this comment.
I think the problem is not that we are missing this object, but that the indexer should not be referencing this object.
There was a problem hiding this comment.
Don't disagree. Was shooting to put up a quick fix and move on to other fires.
There was a problem hiding this comment.
I'm fairly certain we can delete all of this: https://github.com/sul-dlss/hydrus/blob/dd3a54246e9c35a179d6c0c86dc446df47500194/app/indexers/rights_metadata_datastream_indexer.rb#L19-L62
There was a problem hiding this comment.
@jcoyne OK, I'll have a look.
There was a problem hiding this comment.
@jcoyne if I remove all the dra stuff in the rights metadata datastream indexer, it's not going to be doing very much, which has me wondering why we have all this code in Hydrus now. I'm not eager to do a deep dive on this one.
There was a problem hiding this comment.
This was added so that we could upgrade to the latest version of dor-services which does not have its own indexing. This indexing code was for Dor::RightsMetadataDS not for Hydrus::RightsMetadataDS
It currently is fundamentally broken: https://app.honeybadger.io/projects/49897/faults/67008277
mjgiarlo
force-pushed
the
rights-indexing-fix
branch
from
dd3a542 to
d0bb325
Compare
mjgiarlo
changed the title
|
This PR currently makes things worse. I can't even load the index page on stage. Planning to pair with @aaron-collier in the morning. |
|
@jcoyne is going to take over this work. Feel free to nuke this branch/PR or re-purpose it. |
Why was this change made?
It currently is fundamentally broken: https://app.honeybadger.io/projects/49897/faults/67008277
How was this change tested?
CI and integration tests on stage (to be run soon)
Which documentation and/or configurations were updated?
None