Add a fix for elements overflowing the grid #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dude, thank you. this bug was totally confusing me. much nicer than using overflow: hidden on the grid cell when these cases arise. |
| @@ -103,11 +103,14 @@ | |||
| * utility or a component class that extends 'Grid'. | |||
| * | |||
| * 1. Set flex items to full width by default | |||
| * 2. Fix issue where elements with overflow extend past the | |||
| * `Grid-cell` container. | |||
There was a problem hiding this comment.
Maybe you can create a git.io shorturl and add it here?
|
|
|
There is not. Perhaps I should open one. I thought the commit message was quite detailed. Perhaps I could include a link to it or this PR? |
|
Yeah that'd would do it too - it'd give people more context. |
|
@giuseppeg Good idea, done. I'll look at opening an issue on flexbugs too. |
Flex items have a min-width set to `auto` as per the spec: https://www.w3.org/TR/css-flexbox/#min-size-auto This causes elements like `pre` to extend past the `Grid-cell` even when overflow is set. Setting `min-width` to `0` fixes this and gives a more expected behaviour in that situation. Bug example: http://codepen.io/simonsmith/pen/BKGKBo More detail: http://weblog.west-wind.com/posts/2016/Feb/15/Flexbox-Containers-PRE-tags-and-managing-Overflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flex items have a min-width set to
autoas per the spec:https://www.w3.org/TR/css-flexbox/#min-size-auto
This causes elements like
preto extend past theGrid-celleven whenoverflow is set.
Setting
min-widthto0fixes this and gives a more expectedbehaviour in that situation.
Bug example: http://codepen.io/simonsmith/pen/BKGKBo
More detail: http://weblog.west-wind.com/posts/2016/Feb/15/Flexbox-Containers-PRE-tags-and-managing-Overflow
Have tested in several browsers and seems to work as expected