-
Notifications
You must be signed in to change notification settings - Fork 962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collapsible define temperament and define mode blocks #2934
Conversation
Please share your suggestions and feedback @walterbender. Q: Should these blocks be in "collapsed" state when generated from a widget (as in the case of action block generated from the custom mode widget)? Thanks. |
collapsed is a good idea. |
To present the define mode and define temperament blocks in the collapsed state, I passed the |
I am not sure why the temperament stacks are often problematic when they load... I'll investigate. |
I tracked the state of the End Result: temp.mp4Please give your thoughts on this @walterbender. |
Please share your feedback and suggestions @walterbender @pikurasa . |
This looks good. I have not merged it yet because I am working on a major overhaul, to which I will migrate your patch. |
FYI: 6eef801 |
* clean up many un/misdeclared variables * use getter/setter for octaveRatio * use functions to access TEMPERAMENT * eslint * refactor to eliminate most globals and all eslint errors * no longer supported * refactor in response to activity.js refactoring * refactor in response to activity.js refactoring * refactor in response to activity.js refactoring * refactor in response to activity.js refactoring * refactor in response to activity.js refactoring * refactor in response to activity.js refactoring * refactoring due to changes to activity.js * wrong case on exported * inadvertently removed * temporarily disable plugins and myblocks * fix inconsistency with cameraID * fix regression with custom pitch block * handle neg. cents * fix regression in stage * fix regression with grid * fix my blocks code * fix regression in collapse graphics * update maths plugin to reflect new format * add support for flow plugins * add external support for hideArrows * linting * mark as deprecated * refactor to new format * refactor plugin global storage * updates for new refactor * more changes to fix long-standing regressions with plugins * more plugin updates * updated to new format * wrapping up plugin changes * fix lint warnings * don't use global lint disable * missed one * Fixes Mouse Name Block Connection issues #2942 * Fix: Print simultaneous with the note #2938 * Fixed : NaN appearing in Stats #2937 * Collapsible define temperament and define mode blocks #2934 * [email protected] * fixes #2907: When new project button is pressed, the original project is first saved #2923 * missed some tweaks due to refactoring * don't crash when macros as malformed * lint Co-authored-by: Kumar Saurabh Raj <[email protected]> Co-authored-by: Daksh Shah <[email protected]> Co-authored-by: Joykirat Singh <[email protected]> Co-authored-by: Daksh Doshi <[email protected]> Co-authored-by: tborich <[email protected]>
Merged as part of #2943 |
Issue Reference: #2931
Define temperament and define mode are now collapsible blocks.