Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in 120 beats per minute, 1/12 beat value #1842

Closed
smurata opened this issue Aug 27, 2019 · 12 comments
Closed

bug in 120 beats per minute, 1/12 beat value #1842

smurata opened this issue Aug 27, 2019 · 12 comments
Labels
Issue-Bug WF1-Need more info We need more info in order to proceed
Milestone

Comments

@smurata
Copy link

smurata commented Aug 27, 2019

@pikurasa
@walterbender

I tried 120 beats per minute, 1/12 beat value in the Japanese version.
The performance is not right.

https://youtu.be/R8KNPxm7VeM

@smurata
Copy link
Author

smurata commented Aug 27, 2019

@pikurasa
@walterbender

Sorry. The link above doesn't work.
Please try this.

https://youtu.be/R8KNPxm7VeM

@walterbender
Copy link
Member

Can you please share the project itself. Would make debugging easier

@smurata
Copy link
Author

smurata commented Aug 27, 2019

@pikurasa
Copy link
Collaborator

I did some tests (on Abrowser 65.0.1, 64 bit, Trisquel 8.0, Japanese Mode) and noticed the following:

(@smurata first I put all the action blocks into a instrument clamp to simplify the code)

2019-08-27.zip

  1. Some notes, even in my simplified version do not play the specified instrument, "synthesizer" (シンセサイザー). It seems like ソ and the last シ are problematic. Actually, those notes are the longest notes, too.
  2. Choosing 1/8 instead of 1/12 does not cause the issue in number 1 above
  3. Choosing a different instrument, such as piano or guitar does not cause the same issue.

I suspect that the synthesizer sound is not being called for any note value greater than 1/12 for meter of 120 and beat value equal to 1/12. Some initial tests seem to prove this to be the case.

Hope that helps.

@walterbender
Copy link
Member

I am able to play this with no problems. Are you sure you are using the version with my recent patch?

@walterbender
Copy link
Member

What synth causes the problem?

@smurata
Copy link
Author

smurata commented Aug 27, 2019

@pikurasa
@walterbender

I opened the newest Music Block @pikurasa made. It is published on 'planet'. I downloaded it from there.

The denominator numbers of both beat value and note value cannot be changed.
The number of BPM cannot be changed.

Here is the demonstration.

https://youtu.be/NYkh_CCl9n8

@walterbender
Copy link
Member

walterbender commented Aug 27, 2019 via email

@pikurasa
Copy link
Collaborator

I don't know anything about "Devin's" version of Music Blocks.

@walterbender I do not have a separate version. I have a page that links to rawgit. Since the URL for rawgit is hard to memorize, I often send people to my page with the links, so that they can find the rawgit version easily.

If you see the URL at 21 seconds through Sachiko's video, you will see that she is testing from the Rawgit master.

Next time I test, I will copy the console.

@pikurasa
Copy link
Collaborator

Next time I test, I will copy the console.

The console is not working for me (yes, I know Shift-Ctl-J -- it just is not working in this version of Abrowser, which is the browser I use to test Japanese)

At any rate, it seems I put the wrong file for the "simplified version" above. Here is the simplified version (all action blocks contained within a single instrument block):

bug test. BPM block.08.26.2019-devin-simple.html.zip

I get the same results as Sachiko describes. Remember, it must be in Japanese mode.

@walterbender
Copy link
Member

I tried in Japanese. Works fine for me. Is there a particular synth that triggers the issue?

My console log, FWIW:

c major
js/logo.js:8689 notes to play: C4 1/12
2js/utils/musicutils.js:93 c major
js/logo.js:8689 notes to play: D4 1/12
2js/utils/musicutils.js:93 c major
js/logo.js:8689 notes to play: E4 1/12
2js/utils/musicutils.js:93 c major
js/logo.js:8689 notes to play: G4 1/4
2js/utils/musicutils.js:93 c major
js/logo.js:8689 notes to play: A4 1/12
2js/utils/musicutils.js:93 c major
js/logo.js:8689 notes to play: G4 1/12
2js/utils/musicutils.js:93 c major
js/logo.js:8689 notes to play: F4 1/12
2js/utils/musicutils.js:93 c major
js/logo.js:8689 notes to play: B4 1/12
2js/utils/musicutils.js:93 c major
js/logo.js:8689 notes to play: G4 1/12
2js/utils/musicutils.js:93 c major
js/logo.js:8689 notes to play: B4 1/12

@walterbender walterbender added Issue-Bug WF1-Need more info We need more info in order to proceed labels Sep 29, 2019
@walterbender walterbender added this to the future milestone Nov 10, 2019
@walterbender
Copy link
Member

Please reopen if this still happens. I cannot reproduce it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug WF1-Need more info We need more info in order to proceed
Projects
None yet
Development

No branches or pull requests

3 participants