Fix: Corrected MIDI pitch note addition bug (#4216)

* Fix: Corrected MIDI pitch addition bug * Fix: Corrected MIDI pitch addition bug
sugarlabs · Jan 3, 2025 · ba4ec7f · ba4ec7f
1 parent f0ac406
commit ba4ec7f
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/js/widgets/musickeyboard.js b/js/widgets/musickeyboard.js
@@ -1917,7 +1917,7 @@ function MusicKeyboard(activity) {
     this._createAddRowPieSubmenu = function () {
         docById("wheelDivptm").style.display = "";
         // docById("wheelDivptm").style.zIndex = "300";
-        const pitchLabels = ["do", "re", "mi", "fa", "sol", "la", "ti"];
+        const pitchLabels = ["do", "do♯", "re", "re♯", "mi", "fa", "fa♯", "sol", "sol♯", "la", "la♯", "ti"];
         const hertzLabels = [262, 294, 327, 348, 392, 436, 490, 523];
         const VALUESLABEL = ["pitch", "hertz"];
         const VALUES = ["imgsrc: images/chime.svg", "imgsrc: images/synth.svg"];
@@ -2022,7 +2022,10 @@ function MusicKeyboard(activity) {
                     }
                 }
 
-                rLabel = pitchLabels[(i + 1) % pitchLabels.length];
+                do {
+                    rLabel = pitchLabels[(i + 1) % pitchLabels.length];
+                    i = (i + 1) % pitchLabels.length;
+                } while (this.layout.some(note => note.noteName === rLabel));
                 for (let j = this.layout.length; j > 0; j--) {
                     rArg = this.layout[j - 1].noteOctave;
                     if (isNaN(rArg)) {
@@ -2115,6 +2118,11 @@ function MusicKeyboard(activity) {
                     this.displayLayout = this.displayLayout.concat(sortedHertzList);
                     this._createKeyboard();
                     this._createTable();
+                    const n = this.layout.length;
+                    const key = this.layout[n - 1];
+                    this.getElement[key.noteName.toString() + key.noteOctave.toString()] = key.objId;
+                    this.getElement[FIXEDSOLFEGE1[key.noteName.toString()] + "" + key.noteOctave] =
+                        key.objId; //convet solfege to alphabetic.
                 }, 500);
             } else {
                 // eslint-disable-next-line no-console