Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #97 #100

Closed
wants to merge 1 commit into from
Closed

Fixes #97 #100

wants to merge 1 commit into from

Conversation

cemeiq
Copy link

@cemeiq cemeiq commented Jan 15, 2019

No description provided.

@quozl
Copy link
Contributor

quozl commented Jan 16, 2019

Thanks. Reviewed. Comments;

  • you added and removed blank lines; please remove those changes,
  • your changes are way more complicated than, and inconsistent with, your previous change sugarlabs/pydebug-activity@6be1b0c in pull request Fixes #7 pydebug-activity#8; is there a reason you did not use the same method? See also sugarlabs/read-sd-comics@f6a9999.
  • I note the CI failure. I'm not sure this activity is in a working state. Your commit messages did not mention any testing or testing environment. Did the activity work for you?

@cemeiq cemeiq force-pushed the Port_from_GConf_to_Gio.Settings branch 2 times, most recently from 16fb463 to ba75500 Compare January 17, 2019 16:43
@rhl-bthr
Copy link

Reviewed ba75500.
No change in review comments

@cemeiq
Copy link
Author

cemeiq commented Jan 17, 2019

@quozl, @pro-panda Yes, the activity was tested on Fedora 28. It did not work for me. I'm closing the pull request as CI is failing.

@cemeiq cemeiq closed this Jan 17, 2019
@quozl quozl mentioned this pull request Feb 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cemeiq @quozl @rhl-bthr