Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to Gtk3 #5

Merged
merged 3 commits into from
Nov 4, 2018
Merged

Port to Gtk3 #5

merged 3 commits into from
Nov 4, 2018

Conversation

tonadev
Copy link
Contributor

@tonadev tonadev commented Oct 31, 2018

Explanation

Fix #1. This PR ports to Gtk3.

Reason

GTK+ 2 and GStreamer 0.10 are end of life.

Test result

tonadev@TDPC:~/Documents/Work/OpenSource/code_in/sugarlabs/bichos2/bichos-activity$ sugar-activity

(sugar-activity:5552): Gtk-WARNING **: 21:55:19.290: Theme parsing error: gtk-widgets.css:16:32: The style property GtkExpander:expander-size is deprecated and shouldn't be used anymore. It will be removed in a future version

(sugar-activity:5552): Gtk-WARNING **: 21:55:19.291: Theme parsing error: gtk-widgets.css:17:35: The style property GtkExpander:expander-spacing is deprecated and shouldn't be used anymore. It will be removed in a future version
Corriendo Intro . . .
Corriendo Canta Bichos . . .

(sugar-activity:5552): Gtk-WARNING **: 21:55:21.668: Attempting to add a widget with type CantaBichos+CantaBichos+Dialog to a SugarBichos+Bichos, but as a GtkBin subclass a SugarBichos+Bichos can only contain one widget at a time; it already contains a widget of type GtkVBox
Gtk-Message: 21:55:21.671: GtkDialog mapped without a transient parent. This is discouraged.

(sugar-activity:5552): Gtk-CRITICAL **: 21:55:47.535: gtk_widget_draw: assertion '!widget->priv->alloc_needed' failed


tonadev@TDPC:~/Documents/Work/OpenSource/code_in/sugarlabs/bichos2/bichos-activity$ sugar-activity

(sugar-activity:5520): Gtk-WARNING **: 21:53:47.699: Theme parsing error: gtk-widgets.css:16:32: The style property GtkExpander:expander-size is deprecated and shouldn't be used anymore. It will be removed in a future version

(sugar-activity:5520): Gtk-WARNING **: 21:53:47.699: Theme parsing error: gtk-widgets.css:17:35: The style property GtkExpander:expander-spacing is deprecated and shouldn't be used anymore. It will be removed in a future version
Corriendo Intro . . .
Corriendo Canta Bichos . . .

(sugar-activity:5520): Gtk-WARNING **: 21:53:49.920: Attempting to add a widget with type CantaBichos+CantaBichos+Dialog to a SugarBichos+Bichos, but as a GtkBin subclass a SugarBichos+Bichos can only contain one widget at a time; it already contains a widget of type GtkVBox
Gtk-Message: 21:53:49.922: GtkDialog mapped without a transient parent. This is discouraged.

tonadev@TDPC:~/Documents/Work/OpenSource/code_in/sugarlabs/bichos2/bichos-activity$ sugar-activity

(sugar-activity:5533): Gtk-WARNING **: 21:54:10.521: Theme parsing error: gtk-widgets.css:16:32: The style property GtkExpander:expander-size is deprecated and shouldn't be used anymore. It will be removed in a future version

(sugar-activity:5533): Gtk-WARNING **: 21:54:10.522: Theme parsing error: gtk-widgets.css:17:35: The style property GtkExpander:expander-spacing is deprecated and shouldn't be used anymore. It will be removed in a future version
Corriendo Intro . . .
Corriendo Ojos Compuestos . . .

(sugar-activity:5533): Gtk-WARNING **: 21:54:13.376: Attempting to add a widget with type OjosCompuestos+OjosCompuestos+Dialog to a SugarBichos+Bichos, but as a GtkBin subclass a SugarBichos+Bichos can only contain one widget at a time; it already contains a widget of type GtkVBox
Gtk-Message: 21:54:13.397: GtkDialog mapped without a transient parent. This is discouraged.

Observations (Not sure if port errors):

  • When clicking CucaraSims, and then a button, it appears a 'dialog' and most of it is blank.
  • Icon in sound button in CucaraSims doesn't appear until you click it and then it disappears again.
  • When clicking "canciones" it zooms and doesn't stop.
  • __selecciones method seems not to work properly. (clicking an image does nothing)
  • When clicking "imagenes" the column at the right blinks.

@rhl-bthr
Copy link

Thanks @tonadev. Great work.
Re the observations, please verify if they were present before your port.

@tonadev
Copy link
Contributor Author

tonadev commented Oct 31, 2018

@pro-panda I can't. Its impossible to me to test it as I have no Gst 0.10 and it's no longer available for download. I have been looking for solutions but really don't know what is causing the problems.

@chimosky
Copy link
Member

chimosky commented Nov 1, 2018

@tonadev nice work.

Does the logs say anything?

Few comments:
change callback name of draw signal in CantaBichos/CantaBichos.py to _draw_cb
In CucaraSims/JAMediaImagenes/ImagePlayer.py you used
self.xid = self.ventana.get_property('window').get_xid() but in Main.py you used
xid = escenario.get_property('window').get_xid, please be consistent.

@tonadev
Copy link
Contributor Author

tonadev commented Nov 2, 2018

@chimosky

change callback name of draw signal in CantaBichos/CantaBichos.py to _draw_cb

Done (2fde972)

In CucaraSims/JAMediaImagenes/ImagePlayer.py you used
self.xid = self.ventana.get_property('window').get_xid() but in Main.py you used
xid = escenario.get_property('window').get_xid, please be consistent.

That's part of the original code, not mine. Should I change it anyways?

@tonadev tonadev mentioned this pull request Nov 2, 2018
@chimosky
Copy link
Member

chimosky commented Nov 2, 2018

That's part of the original code, not mine. Should I change it anyways?

The port is done by you, be consistent with the methods you use. .get_xid accesses the method and doesn't return anything, get_xid() does the opposite.

@tonadev
Copy link
Contributor Author

tonadev commented Nov 2, 2018

Sorry @chimosky, I misunderstood your comment. I added the missing parentheses in the last commit. However the problems persists.

@rhl-bthr rhl-bthr merged commit becbbe1 into sugarlabs:master Nov 4, 2018
@rhl-bthr
Copy link

rhl-bthr commented Nov 4, 2018

@tonadev Thanks
Please open relevant issues from your observations

@tonadev tonadev deleted the port-to-gtk3 branch November 4, 2018 17:04
@tonadev tonadev mentioned this pull request Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants