Fix Fabfile #2
Open
Fix Fabfile #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commits intends to fix the old fabfile which is used to automate installation part. Changes done 1.) local() was removed with os.system() , since utlimately it is used to invoke shell commands and couldn't find any function/module named in python which does that 2.) Change upstream of downloading sphinx. At the time of writing version 0.9.9 is more than 2 years old and have archived. Affects bin/fabfile.py
|
Reviewed. Can't see how it ever worked, as local was not defined. Don't think build process needs CI. |
|
So I guess it's ready to be merged? |
|
Needs a maintainer to merge. I'm just an interested party. |
|
@samswag Could you please test this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits intends to fix the old fabfile which is used to automate
installation part. Changes done
1.) local() was removed with os.system() , since utlimately it is used
to invoke shell commands and couldn't find any function/module named in
python which does that
2.) Change upstream of downloading sphinx. At the time of writing
version 0.9.9 is more than 2 years old and have archived.
Affects
bin/fabfile.pyI am also thinking out to verify build process by running automated tests post commit on Github using something like Travis CI (or another CI system as long as it works) ?