Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand only UTF-8 file #430

Merged
merged 4 commits into from
Oct 4, 2020
Merged

Expand only UTF-8 file #430

merged 4 commits into from
Oct 4, 2020

Conversation

sue445
Copy link
Owner

@sue445 sue445 commented Oct 4, 2020 •
edited
Loading

When we post non UTF-8 blob url (e.g. image) to slack, broken text is attached in slack 😩

So I tried not to attach this.

Close #428

Example

image

image

sjis

image

@sue445
Copy link
Owner Author

sue445 commented Oct 4, 2020

After deployed

image

@sue445 sue445 merged commit 3f526e4 into master Oct 4, 2020
@sue445 sue445 deleted the feature/expand_only_utf8 branch October 4, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid unpacking binary url
1 participant
@sue445