Support blob link without line hash

[suusan2go]

Thank you for creating this great tool!

Currently, gitpanda does not support a blob link without Line Hash.
But GitHub integration on Slack supports a link without Line Hash like this.

So I think it would be great if gitpanda can support blob link without line hash like GitHub!

[sue445]

Please add a test case for this patch.

See followings.

gitpanda/gitlab/url_parser_test.go

Lines 519 to 572 in 39c589b

	{
	name: "Blob URL (single line)",
	args: args{
	url: "http://example.com/diaspora/diaspora-project-site/blob/master/gitlabci-templates/continuous_bundle_update.yml#L4",
	},
	want: &Page{
	Title: "gitlabci-templates/continuous_bundle_update.yml:4",
	Description: "```\n variables:\n```",
	AuthorName: "",
	AuthorAvatarURL: "",
	AvatarURL: "http://example.com/uploads/project/avatar/3/uploads/avatar.png",
	CanTruncateDescription: false,
	FooterTitle: "diaspora/diaspora-project-site",
	FooterURL: "http://example.com/diaspora/diaspora-project-site",
	FooterTime: nil,
	Color: "",
	},
	},
	{
	name: "Blob URL (single line & including /-/)",
	args: args{
	url: "http://example.com/diaspora/diaspora-project-site/-/blob/master/gitlabci-templates/continuous_bundle_update.yml#L4",
	},
	want: &Page{
	Title: "gitlabci-templates/continuous_bundle_update.yml:4",
	Description: "```\n variables:\n```",
	AuthorName: "",
	AuthorAvatarURL: "",
	AvatarURL: "http://example.com/uploads/project/avatar/3/uploads/avatar.png",
	CanTruncateDescription: false,
	FooterTitle: "diaspora/diaspora-project-site",
	FooterURL: "http://example.com/diaspora/diaspora-project-site",
	FooterTime: nil,
	Color: "",
	},
	},
	{
	name: "Blob URL (multiple line)",
	args: args{
	url: "http://example.com/diaspora/diaspora-project-site/blob/master/gitlabci-templates/continuous_bundle_update.yml#L4-9",
	},
	want: &Page{
	Title: "gitlabci-templates/continuous_bundle_update.yml:4-9",
	Description: "```\n variables:\n CACHE_VERSION: \"v1\"\n GIT_EMAIL: \"[email protected]\"\n GIT_USER: \"GitLab CI\"\n LABELS: \"bundle update\"\n OPTIONS: \"\"\n```",
	AuthorName: "",
	AuthorAvatarURL: "",
	AvatarURL: "http://example.com/uploads/project/avatar/3/uploads/avatar.png",
	CanTruncateDescription: false,
	FooterTitle: "diaspora/diaspora-project-site",
	FooterURL: "http://example.com/diaspora/diaspora-project-site",
	FooterTime: nil,
	Color: "",
	},
	},

[suusan2go]

@sue445 sorry I didn't think test cases for blob fetcher covered in url_parser_test.go 😅 I add a test case for this patch, so can you review this again?

[sue445]

LGTM!

[sue445]

I released as v0.9.1

• https://github.com/sue445/gitpanda/releases/tag/v0.9.1
• https://github.com/sue445/gitpanda/blob/master/CHANGELOG.md#v091