Resolve CMake Support for MCUboot Example #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 21, 2021 13:07
The mcuboot.lib files now point to lambda-shuttle/mcuboot, which contains support for CMake.
The path now includes the full path to this header, which lives under the flash_map_backend folder of the mbed-mcuboot port's include directory.
pan-
approved these changes
Sep 21, 2021
|
|
||
| target_link_libraries(${APP_TARGET} | ||
| PUBLIC | ||
| mbed-os |
There was a problem hiding this comment.
Is there a reason to have different indentation ?
There was a problem hiding this comment.
Oh interesting... I could revert this to the previous style if you'd like. I maintained this style of indentation in the CMakeLists.txt files I wrote for both the mbed-mcuboot port and its examples. It's consistent with that followed in the mcuboot/boot/bootutil/CMakeLists.txt. I do notice that the indentation style of mcuboot/boot/espressif/CMakeLists.txt seems to match the previous style.
sudotensor
force-pushed
the
cmake-support
branch
from
e0455f0 to
acf5581
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to the associated issue (#3) for more information. In summary, support for building the MCUboot example with the new
mbed-toolswas added; this involved the creation of CMakeLists.txt files and updating the library information for mcuboot.Closes #3