Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Esp32v3 initial support #113

Merged
merged 6 commits into from
Nov 28, 2021
Merged

Esp32v3 initial support #113

merged 6 commits into from
Nov 28, 2021

Conversation

code8buster
Copy link
Contributor

Please ensure platformio.ini does not point to my personal repository for LoRaLayer2. I don't know how that got wrapped up in there, and I'm not practiced with git.

esp32-v3 hardware still does not initialize the radios with these modifications but at the least, it instantiates the Layer 1 wrapper for the Ebyte SX1262 modules correctly without error.

All commits including my rookie mistakes!

@samuk
Copy link
Collaborator

samuk commented Nov 25, 2021

Thanks! I'm not really in a position to be able to review this, I'll try and find someone who is though. See #110

@paidforby
Copy link
Contributor

I'll take a look at it tomorrow. If I can find my dev board I'll even try validating the changes. Thanks for paying attention to this @samuk

@@ -34,7 +35,7 @@ lib_deps =
ESP Async [email protected]
[email protected]
https://github.com/jgromes/RadioLib#3682c6c9215891e3afb7672f1235fde1c3bd75fd
https://github.com/sudomesh/LoRaLayer2#efaa3fa73e3c8f6a7c66e335873c0bd81cc865e3
https://github.com/code8buster/LoRaLayer2.git#esp32v3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After merging both PRs, we should point this back at ""official" LoRaLayer2 latest commit.

@paidforby
Copy link
Contributor

Both the esp32v3 and ttgo-lora32v2 envs compiled fine. I'll let TravisCI finish testing the other boards. Don't have access to my DR dev board right now to actually test loading the compiled firmware, though I am under the impression from @code8buster that the LoRa's don't initialize just yet.

I'll also accept the PR to LoRaLayer2 and fix the platformio.ini that currently points at @code8buster fork.

@paidforby paidforby merged commit 0a6e1de into sudomesh:master Nov 28, 2021
@code8buster code8buster deleted the esp32v3 branch May 7, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants