Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base layout #2

Closed
wants to merge 4 commits into from
Closed

Add base layout #2

wants to merge 4 commits into from

Conversation

davelange
Copy link

Why:

  • New layout has a sidebar nav wrapping all pages except Onboarding

How

  • Add a BaseLayout and Sidebar components that wrap the pages content. Not styled yet.
  • Move the wallet widget and behaviour in to the BaseLayout, as it will be present on all these pages.

@davelange
Copy link
Author

@juliangruber while the other PRs are pending, I prepared this one to setup the new app layout structure.

Copy link

@juliangruber juliangruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I've pinged Miro on Slack about these reviews

@@ -6,6 +6,7 @@ import Sentry from 'src/components/Sentry'
import Plausible from 'src/components/Plausible'
import { HelmetProvider, Helmet } from 'react-helmet-async'
import { ROUTES } from 'src/lib/routes'
import BaseLayout from 'src/components/BaseLayout'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we call this Layout instead?

@juliangruber
Copy link

could you please recreate this PR on the main repo?

@davelange davelange closed this Apr 26, 2024
@davelange davelange deleted the dl/add-base-layout branch June 11, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants