feat: add ROLLUP, CUBE grouping expansion #783
+40
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yongchul
requested review from
jacques-n,
cpcloud,
westonpace,
EpsilonPrime and
vbarua
as code owners
|
|
jcamachor
reviewed
Feb 4, 2025
| // at corresponding index. The expressions sharing the same non-zero values | ||
| // in this field formulates a composite grouping expression (i.e., those | ||
| // columns considered as one grouping expression). | ||
| // For GROUNPING_EXPANSION_UNSPECIFIED, this field is ignored. |
There was a problem hiding this comment.
nit. Typo: GROUNPING_EXPANSION_UNSPECIFIED
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add ROLLUP, CUBE grouping expansion
Adds ROLLUP and CUBE grouping expansions to
AggregateRel. See #782 for rationale.AggregateRel.GroupingExpansionenum to denote expansion type.expansionfield toAggregateRel.Groupingto specify expansion type in a grouping set.composite_grounping_expressionsfield toAggregateRel.Groupingto support composite grouping expression.Refs: #782