Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dynamic parameter expression #780

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

jcamachor
Copy link
Contributor

@jcamachor jcamachor commented Jan 24, 2025

feat: This PR adds a dynamic parameter expression to Substrait.

A dynamic parameter expression represents a placeholder within an expression whose value is determined at runtime.
This is particularly useful for parameterized queries where certain values are not known until execution.
Additionally, using dynamic parameters can enable other use cases, such as sharing execution plans without embedding sensitive information.

Copy link

ACTION NEEDED

Substrait follows the Conventional Commits
specification
for
release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

@jcamachor jcamachor changed the title feat: Add dynamic parameter expression feat: add dynamic parameter expression Jan 24, 2025
EpsilonPrime
EpsilonPrime previously approved these changes Jan 30, 2025
proto/substrait/plan.proto Show resolved Hide resolved
proto/substrait/plan.proto Outdated Show resolved Hide resolved
Copy link
Contributor

@jacques-n jacques-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the iteration patience @jcamachor !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants