Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update the doc to clarify that function names are case-sensitive #757

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

scgkiran
Copy link
Contributor

No description provided.

Copy link
Contributor

@jacques-n jacques-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for update. +1 for me.

@westonpace , @vbarua , @EpsilonPrime can you confirm.

Note the only actual change here is being explicit that the name of a function in substrait definitions is case sensitive. This was always intended but not explicit. It is to support the goal of keeping things simple for consumers. (They don't need to canonicalize or something to match.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants