Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change the type of the bool_and testcase to aggregate #756

Merged
merged 1 commit into from
Dec 19, 2024
Merged

fix: change the type of the bool_and testcase to aggregate #756

merged 1 commit into from
Dec 19, 2024

Conversation

EpsilonPrime
Copy link
Member

No description provided.

@EpsilonPrime EpsilonPrime changed the title fix: change the type of the bool_and test to aggregate fix: change the type of the bool_and testcase to aggregate Dec 17, 2024
scgkiran
scgkiran reviewed Dec 17, 2024
View reviewed changes
tests/cases/boolean/bool_and.test
@@ -1,4 +1,4 @@
### SUBSTRAIT_SCALAR_TEST: v1.0
### SUBSTRAIT_AGGREGATE_TEST: v1.0
Copy link
Contributor

@scgkiran scgkiran Dec 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bool.and is a scalar function with variadic args. We should fix the tests.

Copy link
Member Author

@EpsilonPrime EpsilonPrime Dec 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is boolean.bool_and: https://github.com/substrait-io/substrait/blob/main/extensions/functions_boolean.yaml#L118

boolean.and is indeed a scalar.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I missed the _ part.

scgkiran
scgkiran approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@scgkiran scgkiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/cases/boolean/bool_and.test
@@ -1,4 +1,4 @@
### SUBSTRAIT_SCALAR_TEST: v1.0
### SUBSTRAIT_AGGREGATE_TEST: v1.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I missed the _ part.

@EpsilonPrime EpsilonPrime merged commit 50f1a2e into substrait-io:main Dec 19, 2024
15 checks passed
@EpsilonPrime EpsilonPrime deleted the boolean branch December 19, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scgkiran scgkiran scgkiran approved these changes

@jacques-n jacques-n jacques-n approved these changes

@cpcloud cpcloud Awaiting requested review from cpcloud cpcloud is a code owner

@westonpace westonpace Awaiting requested review from westonpace westonpace is a code owner

@vbarua vbarua Awaiting requested review from vbarua vbarua is a code owner

@anshuldata anshuldata Awaiting requested review from anshuldata

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EpsilonPrime @jacques-n @scgkiran