-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add simple linking to the examples #702
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacques-n
reviewed
Sep 19, 2024
Signed-off-by: MBWhite <[email protected]>
mbwhite
requested review from
cpcloud,
westonpace,
EpsilonPrime and
vbarua
as code owners
October 7, 2024 08:53
bvolpato
previously approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few nit suggestions / ideas to make it clearer
Co-authored-by: Bruno Volpato <[email protected]>
Co-authored-by: Bruno Volpato <[email protected]>
thanks @bvolpato I've accepted those changes |
bvolpato
approved these changes
Dec 4, 2024
EpsilonPrime
approved these changes
Dec 4, 2024
westonpace
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple description of the examples and a link to the new one added in the substrait-java repo; this will need to wait until after that is merged to ensure no broken links.,