ci: stop pinning conventional commits #655
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbarua
requested review from
jacques-n,
cpcloud,
westonpace and
EpsilonPrime
as code owners
|
This was pinned in #644 to fix the release, but now it's broken again because it's pinned :sad: In substrait-java unpinning fixed a similar issue: https://github.com/substrait-io/substrait-java/pull/267/files There's probably a proper way to do this to have this stop happening generally, but my motivation actually figure out Javascript dependency weirdness is basically zero at this point. |
gforsyth
reviewed
Jun 26, 2024
| @@ -12,5 +12,5 @@ npx --yes \ | |||
| -p "@semantic-release/github" \ | |||
| -p "@semantic-release/exec" \ | |||
| -p "@semantic-release/git" \ | |||
| -p "conventional-changelog-conventionalcommits@7.0.2" \ | |||
| -p "conventional-changelog-conventionalcommits" \ | |||
There was a problem hiding this comment.
Suggested change
| -p "conventional-changelog-conventionalcommits" \ | |
| -p "conventional-changelog-conventionalcommits@8.0.0" \ |
If we do this and also pin semantic-release itself to "[email protected]" that should prevent this breaking in the future (we just hit this in Ibis, which is where we copied this release process from)
|
Closing in favour of #657 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.