Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow FetchRel to specify a return of ALL results (#622) #627

Merged
merged 1 commit into from
Apr 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions proto/substrait/algebra.proto
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,7 @@ message FetchRel {
// the offset expressed in number of records
int64 offset = 3;
// the amount of records to return
// use -1 to signal that ALL records should be returned
int64 count = 4;
substrait.extensions.AdvancedExtension advanced_extension = 10;
}
Expand Down
10 changes: 5 additions & 5 deletions site/docs/relations/logical_relations.md
Original file line number Diff line number Diff line change
Expand Up @@ -293,11 +293,11 @@ The fetch operation eliminates records outside a desired window. Typically corre

### Fetch Properties

| Property | Description | Required |
| -------- | ------------------------------------------------------------ | ------------------------ |
| Input | A relational input, typically with a desired orderedness property. | Required |
| Offset | A positive integer. Declares the offset for retrieval of records. | Optional, defaults to 0. |
| Count | A positive integer. Declares the number of records that should be returned. | Required |
| Property | Description | Required |
| -------- | --------------------------------------------------------------------- | ------------------------ |
| Input | A relational input, typically with a desired orderedness property. | Required |
| Offset | A non-negative integer. Declares the offset for retrieval of records. | Optional, defaults to 0. |
| Count | A non-negative integer or -1. Declares the number of records that should be returned. -1 signals that ALL records should be returned. | Required |
EpsilonPrime marked this conversation as resolved.
Show resolved Hide resolved

=== "FetchRel Message"

Expand Down
Loading