Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: referenced simple extension in tutorial (set instead of string) #494

Merged
merged 1 commit into from
Apr 17, 2023
Merged

fix: referenced simple extension in tutorial (set instead of string) #494

merged 1 commit into from
Apr 17, 2023

Conversation

mbrobbel
Copy link
Member

@mbrobbel mbrobbel commented Apr 13, 2023 •
edited
Loading

I noticed that the tutorial has functions_string.yaml and functions_set.yaml
mixed up for the index_in extension function. This PR fixes that.

@github-actions
Copy link

ACTION NEEDED

Substrait follows the Conventional Commits
specification for
release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

westonpace
westonpace approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@westonpace westonpace merged commit b5d7ed2 into substrait-io:main Apr 17, 2023
@mbrobbel mbrobbel deleted the fix-tutorial branch April 17, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonpace westonpace westonpace approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbrobbel @westonpace