Skip to content

Commit

Permalink
address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
anshuldata committed Oct 4, 2024
1 parent 5938f28 commit e8b85dd
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions proto/substrait/algebra.proto
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,10 @@ message ReadRel {
substrait.extensions.AdvancedExtension advanced_extension = 10;
}

// A table composed of literals.
// A table composed of expressions.
message VirtualTable {
repeated Expression.Literal.Struct values = 1 [deprecated = true];
repeated Expression expression_values = 2;
repeated Expression expressions = 2;
}

// A stub type that can be used to extend/introduce new table types outside
Expand Down
2 changes: 1 addition & 1 deletion site/docs/relations/logical_relations.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ Read definition types (like the rest of the features in Substrait) are built by
#### Virtual Table

A virtual table is a table whose contents are embedded in the plan itself. The table data
is encoded as records consisting of literal values or an expression that can be resolved without referencing any input data.
is encoded as records consisting of literal values or expressions that can be resolved without referencing any input data.
For example, a literal, a function call involving literals, or any other expression that does
not require input.

Expand Down

0 comments on commit e8b85dd

Please sign in to comment.