Skip to content

Commit

Permalink
fix(text)!: mark name and structure property of type extension …
Browse files Browse the repository at this point in the history
…item as required (#495)

The spec on simple extensions
[states](https://substrait.io/extensions/#simple-extensions):
```
In the places where these entities are referenced, they will be referenced using a URI + name
reference.
```
And for type:
```
Type  | The name as defined on the type object.
```

However this `name` field is not marked as required on the type object
definition in the schema. This PR marks this field as required to make
sure it
can always be referenced.

---------

Co-authored-by: Weston Pace <[email protected]>
  • Loading branch information
mbrobbel and westonpace authored Apr 18, 2023
1 parent b5d7ed2 commit 7246102
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions text/simple_extensions_schema.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ properties:
items:
type: object
additionalProperties: false
required: [name]
properties:
name:
type: string
Expand Down

0 comments on commit 7246102

Please sign in to comment.